The user provides details of what lcores are to run on what cpus in a variety of ways. Map all those to a single array of cpusets in the user_cfg struct, such that each lcore id has a cpuset of physical lcore ids if it is to be used. Then after the parsing of args, we can use that to appropriately populate the runtime configuration.
Signed-off-by: Bruce Richardson <[email protected]> --- lib/eal/common/eal_common_options.c | 146 ++++++++++++++++++---------- lib/eal/common/eal_internal_cfg.h | 11 ++- lib/eal/freebsd/eal.c | 1 + lib/eal/linux/eal.c | 1 + lib/eal/windows/eal.c | 1 + 5 files changed, 108 insertions(+), 52 deletions(-) diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c index 076e939292..bd08d29e1d 100644 --- a/lib/eal/common/eal_common_options.c +++ b/lib/eal/common/eal_common_options.c @@ -524,6 +524,10 @@ eal_reset_internal_config(void) CPU_ZERO(&runtime_state->ctrl_cpuset); runtime_state->init_complete = 0; CPU_ZERO(&user_cfg->service_cpuset); + for (i = 0; i < RTE_MAX_LCORE; i++) { + free(user_cfg->lcore_cpusets[i]); + user_cfg->lcore_cpusets[i] = NULL; + } user_cfg->max_simd_bitwidth.bitwidth = RTE_VECT_DEFAULT_SIMD_BITWIDTH; user_cfg->max_simd_bitwidth.forced = 0; } @@ -888,22 +892,19 @@ eal_parse_service_corelist(const char *corelist, rte_cpuset_t *cpuset) return CPU_COUNT(cpuset) > 0 ? 0 : -1; } +/* Expand a flat cpuset into lcore_cpusets[], assigning lcore IDs. + * If remap is false: lcore_id == physical CPU id (identity mapping). + * If remap is true: lcore IDs are assigned sequentially from remap_base. + * Returns the number of lcores configured, or -1 on error. */ static int -update_lcore_config(const rte_cpuset_t *cpuset, bool remap, uint16_t remap_base) +eal_expand_cpuset_to_map(const rte_cpuset_t *cpuset, bool remap, uint16_t remap_base, + rte_cpuset_t **lcore_cpusets) { - struct eal_runtime_state *runtime_state = eal_get_runtime_state(); unsigned int lcore_id = remap_base; unsigned int count = 0; unsigned int i; int ret = 0; - /* set everything to disabled first, then set up values */ - for (i = 0; i < RTE_MAX_LCORE; i++) { - runtime_state->lcore_cfg[i].role = ROLE_OFF; - runtime_state->lcore_cfg[i].core_index = -1; - } - - /* now go through the cpuset */ for (i = 0; i < CPU_SETSIZE; i++) { if (CPU_ISSET(i, cpuset)) { if (eal_cpu_detected(i) == 0) { @@ -927,11 +928,17 @@ update_lcore_config(const rte_cpuset_t *cpuset, bool remap, uint16_t remap_base) continue; } - runtime_state->lcore_cfg[lcore_id].role = ROLE_RTE; - runtime_state->lcore_cfg[lcore_id].core_index = count; - CPU_ZERO(&runtime_state->lcore_cfg[lcore_id].cpuset); - CPU_SET(i, &runtime_state->lcore_cfg[lcore_id].cpuset); - runtime_state->lcore_cfg[lcore_id].first_cpu = i; + lcore_cpusets[lcore_id] = malloc(sizeof(rte_cpuset_t)); + if (lcore_cpusets[lcore_id] == NULL) { + EAL_LOG(ERR, "failed to allocate cpuset for lcore %u", lcore_id); + for (unsigned int j = 0; j < lcore_id; j++) { + free(lcore_cpusets[j]); + lcore_cpusets[j] = NULL; + } + return -1; + } + CPU_ZERO(lcore_cpusets[lcore_id]); + CPU_SET(i, lcore_cpusets[lcore_id]); EAL_LOG(DEBUG, "lcore %u mapped to physical core %u", lcore_id, i); lcore_id++; count++; @@ -941,9 +948,9 @@ update_lcore_config(const rte_cpuset_t *cpuset, bool remap, uint16_t remap_base) EAL_LOG(ERR, "No valid lcores in core list"); ret = -1; } - if (!ret) - runtime_state->lcore_count = count; - return ret; + if (ret == -1) + return -1; + return (int)count; } static int @@ -1064,7 +1071,6 @@ eal_parse_main_lcore(const char *arg) { char *parsing_end; struct eal_user_cfg *user_cfg = eal_get_user_configuration(); - struct eal_runtime_state *runtime_state = eal_get_runtime_state(); errno = 0; user_cfg->main_lcore = (uint32_t) strtol(arg, &parsing_end, 0); @@ -1078,8 +1084,9 @@ eal_parse_main_lcore(const char *arg) EAL_LOG(ERR, "Error: Main lcore is used as a service core"); return -1; } - /* check that we have the core recorded in the core list */ - if (runtime_state->lcore_cfg[user_cfg->main_lcore].role != ROLE_RTE) { + + /* lcore_cpusets is always populated before eal_parse_main_lcore is called */ + if (user_cfg->lcore_cpusets[user_cfg->main_lcore] == NULL) { EAL_LOG(ERR, "Error: Main lcore is not enabled for DPDK"); return -1; } @@ -1241,15 +1248,18 @@ check_cpuset(rte_cpuset_t *set) * lcore 6 runs on cpuset 0x41 (cpu 0,6) * lcore 7 runs on cpuset 0x80 (cpu 7) * lcore 8 runs on cpuset 0x100 (cpu 8) + * + * Writes the physical-CPU affinity for each mentioned lcore_id into + * cpusets[lcore_id]. Slots not mentioned are left as NULL. + * Returns the number of distinct lcore IDs configured, or -1 on error. */ static int -eal_parse_lcores(const char *lcores) +eal_parse_lcores_to_map(const char *lcores, rte_cpuset_t **cpusets) { - struct eal_runtime_state *runtime_state = eal_get_runtime_state(); rte_cpuset_t lcore_set; unsigned int set_count; - unsigned idx = 0; - unsigned count = 0; + unsigned int idx; + int count = 0; const char *lcore_start = NULL; const char *end = NULL; int offset; @@ -1266,14 +1276,6 @@ eal_parse_lcores(const char *lcores) CPU_ZERO(&cpuset); - /* Reset lcore config */ - for (idx = 0; idx < RTE_MAX_LCORE; idx++) { - runtime_state->lcore_cfg[idx].role = ROLE_OFF; - runtime_state->lcore_cfg[idx].core_index = -1; - CPU_ZERO(&runtime_state->lcore_cfg[idx].cpuset); - runtime_state->lcore_cfg[idx].first_cpu = UINT16_MAX; - } - /* Get list of cores */ do { while (isblank(*lcores)) @@ -1322,7 +1324,7 @@ eal_parse_lcores(const char *lcores) /* without '@', by default using lcore_set as cpuset */ if (*lcores != '@') - rte_memcpy(&cpuset, &lcore_set, sizeof(cpuset)); + memcpy(&cpuset, &lcore_set, sizeof(cpuset)); set_count = CPU_COUNT(&lcore_set); /* start to update lcore_set */ @@ -1331,12 +1333,6 @@ eal_parse_lcores(const char *lcores) continue; set_count--; - if (runtime_state->lcore_cfg[idx].role != ROLE_RTE) { - runtime_state->lcore_cfg[idx].core_index = count; - runtime_state->lcore_cfg[idx].role = ROLE_RTE; - count++; - } - if (lflags) { CPU_ZERO(&cpuset); CPU_SET(idx, &cpuset); @@ -1344,10 +1340,16 @@ eal_parse_lcores(const char *lcores) if (check_cpuset(&cpuset) < 0) goto err; - rte_memcpy(&runtime_state->lcore_cfg[idx].cpuset, &cpuset, - sizeof(rte_cpuset_t)); - runtime_state->lcore_cfg[idx].first_cpu = - (uint16_t)(RTE_CPU_FFS(&cpuset) - 1); + if (cpusets[idx] == NULL) { + cpusets[idx] = malloc(sizeof(rte_cpuset_t)); + if (cpusets[idx] == NULL) { + EAL_LOG(ERR, "failed to allocate cpuset for lcore %u", idx); + ret = -1; + goto err; + } + count++; + } + memcpy(cpusets[idx], &cpuset, sizeof(rte_cpuset_t)); } /* some cores from the lcore_set can't be handled by EAL */ @@ -1360,11 +1362,14 @@ eal_parse_lcores(const char *lcores) if (count == 0) goto err; - runtime_state->lcore_count = count; - ret = 0; - + ret = count; err: - + if (ret == -1) { + for (unsigned int j = 0; j < RTE_MAX_LCORE; j++) { + free(cpusets[j]); + cpusets[j] = NULL; + } + } return ret; } @@ -1916,7 +1921,7 @@ eal_parse_args(void) /* First handle the special case where we have explicit core mapping/remapping */ if (manual_lcore_mapping) { - if (eal_parse_lcores(args.lcores) < 0) { + if (eal_parse_lcores_to_map(args.lcores, user_cfg->lcore_cpusets) < 0) { EAL_LOG(ERR, "invalid lcore mapping list: '%s'", args.lcores); return -1; } @@ -1954,7 +1959,8 @@ eal_parse_args(void) EAL_LOG(DEBUG, "Cores selected by %s: %s", cpuset_source, cpuset_str); free(cpuset_str); } - if (update_lcore_config(&cpuset, remap_lcores, lcore_id_base) < 0) { + if (eal_expand_cpuset_to_map(&cpuset, remap_lcores, lcore_id_base, + user_cfg->lcore_cpusets) < 0) { char *available = available_cores(); EAL_LOG(ERR, "invalid coremask or core-list parameter, please check specified cores are part of %s", @@ -2270,7 +2276,44 @@ eal_cleanup_config(void) free(user_cfg->hugefile_prefix); free(user_cfg->hugepage_dir); free(user_cfg->user_mbuf_pool_ops_name); + for (unsigned int i = 0; i < RTE_MAX_LCORE; i++) { + free(user_cfg->lcore_cpusets[i]); + user_cfg->lcore_cpusets[i] = NULL; + } + + return 0; +} + +static int +eal_apply_lcore_config(void) +{ + struct eal_user_cfg *user_cfg = eal_get_user_configuration(); + + /* lcore_cpusets[] is always populated at parse time for all input forms */ + struct eal_runtime_state *runtime_state = eal_get_runtime_state(); + unsigned int i; + unsigned int count = 0; + for (i = 0; i < RTE_MAX_LCORE; i++) { + if (user_cfg->lcore_cpusets[i] == NULL) { + runtime_state->lcore_cfg[i].role = ROLE_OFF; + runtime_state->lcore_cfg[i].core_index = -1; + CPU_ZERO(&runtime_state->lcore_cfg[i].cpuset); + runtime_state->lcore_cfg[i].first_cpu = UINT16_MAX; + continue; + } + runtime_state->lcore_cfg[i].role = ROLE_RTE; + runtime_state->lcore_cfg[i].core_index = count++; + memcpy(&runtime_state->lcore_cfg[i].cpuset, + user_cfg->lcore_cpusets[i], sizeof(rte_cpuset_t)); + runtime_state->lcore_cfg[i].first_cpu = + (uint16_t)(RTE_CPU_FFS(&runtime_state->lcore_cfg[i].cpuset) - 1); + } + if (count == 0) { + EAL_LOG(ERR, "No valid lcores in core list"); + return -1; + } + runtime_state->lcore_count = count; return 0; } @@ -2280,6 +2323,9 @@ eal_apply_runtime_state(void) struct eal_user_cfg *user_cfg = eal_get_user_configuration(); struct eal_runtime_state *runtime_state = eal_get_runtime_state(); + if (eal_apply_lcore_config() < 0) + return -1; + /* Apply service core roles: service_cpuset bits are lcore IDs */ if (CPU_COUNT(&user_cfg->service_cpuset) > 0) { unsigned int i; @@ -2289,7 +2335,7 @@ eal_apply_runtime_state(void) if (!CPU_ISSET(i, &user_cfg->service_cpuset)) continue; if (runtime_state->lcore_cfg[i].role != ROLE_RTE) { - EAL_LOG(WARNING, + EAL_LOG(WARNING, "service lcore %u is not in the enabled lcore set; ignoring", i); continue; diff --git a/lib/eal/common/eal_internal_cfg.h b/lib/eal/common/eal_internal_cfg.h index 99ffde5c8b..239fe2a7ac 100644 --- a/lib/eal/common/eal_internal_cfg.h +++ b/lib/eal/common/eal_internal_cfg.h @@ -130,8 +130,15 @@ struct eal_user_cfg { uintptr_t base_virtaddr; /**< base address to try and reserve memory from */ uint64_t numa_mem[RTE_MAX_NUMA_NODES]; /**< amount of memory per NUMA node */ uint64_t numa_limit[RTE_MAX_NUMA_NODES]; /**< limit amount of memory per NUMA node */ - rte_cpuset_t service_cpuset; /**< service lcore IDs (bits = lcore IDs to use as service cores) */ - int main_lcore; /**< ID of the main lcore */ + rte_cpuset_t service_cpuset; /**< service lcore IDs (bits = lcore IDs to use as service cores) */ + + /** Per-lcore cpuset array, always populated at arg-parse time for all input forms + * (-c coremask, -l corelist, --lcores with or without '@'/'()'). + * Each non-NULL slot is an individually heap-allocated rte_cpuset_t. + * NULL means the corresponding lcore ID is not configured. + */ + rte_cpuset_t *lcore_cpusets[RTE_MAX_LCORE]; + int main_lcore; /**< ID of the main lcore */ }; /** diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index b1155dfc2c..120425d425 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -744,6 +744,7 @@ rte_eal_init(int argc, char **argv) return fctret; err_out: rte_atomic_store_explicit(&run_once, 0, rte_memory_order_relaxed); + eal_cleanup_config(); eal_clean_saved_args(); return -1; } diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 4c716f2a09..3f2ad98425 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -919,6 +919,7 @@ rte_eal_init(int argc, char **argv) err_out: rte_atomic_store_explicit(&run_once, 0, rte_memory_order_relaxed); + eal_cleanup_config(); eal_clean_saved_args(); return -1; } diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c index e0d7c4e612..b8034dceed 100644 --- a/lib/eal/windows/eal.c +++ b/lib/eal/windows/eal.c @@ -408,6 +408,7 @@ rte_eal_init(int argc, char **argv) return fctret; err_out: + eal_cleanup_config(); eal_clean_saved_args(); return -1; } -- 2.51.0
