Hi Vipin, This is my first ever patch review with DPDK. Apologies if I am not following the right procedure. I welcome any feedback or help in correcting the procedure.
However, I had the following review related to the above patch. I see that changes to app/test/test_ring_perf.c introduced the following functions: get_same_numa_domains(struct lcore_pair *lcp) get_same_l4_domains(struct lcore_pair *lcp) get_same_l3_domains(struct lcore_pair *lcp) get_same_l2_domains(struct lcore_pair *lcp) get_same_l1_domains(struct lcore_pair *lcp) get_two_numa_domains(struct lcore_pair *lcp) get_two_l4_domains(struct lcore_pair *lcp) get_two_l3_domains(struct lcore_pair *lcp) get_two_l2_domains(struct lcore_pair *lcp) get_two_l1_domains(struct lcore_pair *lcp) In the implementation of these, most of the code is pretty much identical, except for the topology domain type. Curious to know if it is better to implement a 'common function' - get_topo_domains(struct lcore_pair *, topology_domain) - as arguments and call get_topo_domains() from all of the above functions. For example: get_same_numa_domains() calls get_topo_domains(lp, RTE_TOPO_DOMAIN_NUMA) This will make it more cleaner and will help changes isolated to one place if there are 'common' issues. Appreciate if you can let me know if my thinking aligns with the correct implementation. Thanks and best regards, Sudheendra G Sampath
