Hi Vincent, On 8/25/2016 12:45 PM, ??? wrote: > From 932e33f33cf2a19ac5fa4295535b6b0e20c61890 Mon Sep 17 00:00:00 2001 > From: Vincent Guo <guopengfei160 at 163.com> > Date: Thu, 25 Aug 2016 17:50:10 +0800 > Subject: [PATCH] kni: bug fix in module_init and module_exit > unregister_XXX should be called when module exits or error occurs > during module init, but register_XXX is called in case that > HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set. >
Patch content is good, thanks for the fix, but patch doesn't apply cleanly (leading spaces are missing) Also in commit log, Signed-off-by and Fixes tags are missing. And commit log can be simpler, something like: "Fix pernet calls when HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set." Would you mind sending a new version of the patch? Thanks, ferruh
