Robin Jarry, Mar 04, 2026 at 12:45: >> With multiple goto labels that function becomes even more complicated. >> Can we just add old_data as an extra parameter: >> __rte_hash_add_key_with_hash(const struct rte_hash *h, const void *key, >> hash_sig_t sig, void *data, void **old_data) >> And make the callers to invoke __hash_rcu_auto_free_old_data()? > > I'll see what I can do for v3.
Unfortunately, I need to pass old_data in order to make the new replace API work. Maybe we can drop the new API altogether and have a much simpler patch. What do you think?
