On 08/23/2016 10:10 AM, Yuanhan Liu wrote: > Due to history reason (that vhost-cuse comes before vhost-user), some > fields for maintaining the vhost-user memory mappings (such as mmapped > address and size, with those we then can unmap on destroy) are kept in > "orig_region_map" struct, a structure that is defined only in vhost-user > source file. > > The right way to go is to remove the structure and move all those fields > into virtio_memory_region struct. But we simply can't do that before, > because it breaks the ABI. > > Now, thanks to the ABI refactoring, it's never been a blocking issue > any more. And here it goes: this patch removes orig_region_map and > redefines virtio_memory_region, to include all necessary info. > > With that, we can simplify the guest/host address convert a bit. > > Signed-off-by: Yuanhan Liu <yuanhan.liu at linux.intel.com> > --- > lib/librte_vhost/vhost.h | 49 ++++++------ > lib/librte_vhost/vhost_user.c | 172 > +++++++++++++++++------------------------- > 2 files changed, 90 insertions(+), 131 deletions(-) >
Thanks for explaining the history behind this. FWIW, the change looks good to me: Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com> Thanks, Maxime
