> -----Original Message-----
> From: Stephen Hemminger <[email protected]>
> Sent: Tuesday, January 27, 2026 4:04 PM
> To: Cliff Burdick <[email protected]>
> Cc: [email protected]; [email protected]
> Subject: Re: [PATCH 0/2] support dmabuf
>
> External email: Use caution opening links or attachments
>
>
> On Tue, 27 Jan 2026 17:44:07 +0000
> Cliff Burdick <[email protected]> wrote:
>
> > Add support for kernel dmabuf feature and integrate it in the mlx5 driver.
> > This feature is needed to support GPUDirect on newer kernels.
> >
> > Cliff Burdick (2):
> > eal: support dmabuf
> > common/mlx5: support dmabuf
> >
> > .mailmap | 1 +
> > drivers/common/mlx5/linux/meson.build | 2 +
> > drivers/common/mlx5/linux/mlx5_common_verbs.c | 48 ++++-
> > drivers/common/mlx5/linux/mlx5_glue.c | 19 ++
> > drivers/common/mlx5/linux/mlx5_glue.h | 3 +
> > drivers/common/mlx5/mlx5_common.c | 28 ++-
> > drivers/common/mlx5/mlx5_common_mr.c | 108 ++++++++++-
> > drivers/common/mlx5/mlx5_common_mr.h | 17 +-
> > drivers/common/mlx5/windows/mlx5_common_os.c | 8 +-
> > drivers/crypto/mlx5/mlx5_crypto.h | 1 +
> > drivers/crypto/mlx5/mlx5_crypto_gcm.c | 3 +-
> > lib/eal/common/eal_common_memory.c | 168 ++++++++++++++++++
> > lib/eal/common/eal_memalloc.h | 21 +++
> > lib/eal/common/malloc_heap.c | 27 +++
> > lib/eal/common/malloc_heap.h | 5 +
> > lib/eal/include/rte_memory.h | 125 +++++++++++++
> > 16 files changed, 576 insertions(+), 8 deletions(-)
> >
>
> Build fails (on MSVC) fix and resubmit.
>
> "cl" "-Ilib\librte_eal.a.p" "-Ilib" "-I..\lib" "-Ilib\eal\common"
> "-I..\lib\eal\common" "-I." "-I.." "-Iconfig" "-I..\config"
> "-Ilib\eal\include" "-I..\lib\eal\include" "-Ilib\eal\windows\include"
> "-I..\lib\eal\windows\include" "-Ilib\eal\x86\include"
> "-I..\lib\eal\x86\include" "-Ilib\eal" "-I..\lib\eal" "-Ilib\argparse" "->
> I..\lib\argparse" "-Ilib\log" "-I..\lib\log" "-Ilib\kvargs" "-I..\lib\kvargs"
> "/MD" "/nologo" "/showIncludes" "/utf-8" "/W3" "/WX" "/std:c11" "/O2" "/Gw"
> "/wd4244" "/wd4267" "/wd4146" "/experimental:c11atomics"
> "/d1experimental:typeof" "/experimental:statementExpressions" "/FI"
> "rte_config.h" "-> D_GNU_SOURCE" "-D_WIN32_WINNT=0x0A00"
> "-DALLOW_EXPERIMENTAL_API" "-DALLOW_INTERNAL_API" "-DABI_VERSION=\"26.1\""
> "-DRTE_LOG_DEFAULT_LOGTYPE=lib.eal"
> "/Fdlib\librte_eal.a.p\eal_common_eal_common_memory.c.pdb"
> /Folib/librte_eal.a.p/eal_common_eal_common_memory.c.obj > "/c"
> ../lib/eal/common/eal_common_memory.c
>../lib/eal/common/eal_common_memory.c(56): error C2143: syntax error: missing
>']' before '...'
>../lib/eal/common/eal_common_memory.c(56): error C2059: syntax error: '...'
>../lib/eal/common/eal_common_memory.c(57): error C2059: syntax error: '}'
Fixed by moving to an init function
