Hi Jan, On Saturday 30 July 2016 01:44 PM, Jan Viktorin wrote: > On Thu, 28 Jul 2016 15:06:10 +0530 > Shreyansh Jain <shreyansh.jain at nxp.com> wrote: > >> Hi Jan, >> >> On Friday 15 July 2016 04:18 PM, Shreyansh jain wrote: >>> On Thursday 14 July 2016 09:27 PM, Jan Viktorin wrote: > > [...] > >>>>>>> (drv).name = RTE_STR(nm); >>>>> >>>>> That is a miss from my side. >>>>> I will publish v7 with this. You want this right away or should I wait a >>>>> little while (more reviews, or any pending additions as per Thomas's >>>>> notes) before publishing? >>>> >>>> Please. The time is almost gone. 18/7/2016 is the release (according >>>> to the roadmap)... I have to fix it in my patchset, otherwise it >>>> does not build (after moving the .name from rte_pci_driver to >>>> rte_driver). >>>> >>> >>> I didn't consider 18/Jul. >>> Please go ahead. I will continue to send v7 _without_ the above change so >>> that your patchset doesn't break. This way you will not get blocked because >>> of me. >>> >> >> Now that we have already skipped the 16.07, I will fix this in my code and >> release an updated version as soon as 16.07 is officially available. Is that >> OK? > > Sure :). The thing is that during August-September, I've got significantly > less time for this then in June-July :/. That's why I was trying to fit in > the 16.07.
Well, then lets try and get things out for review as soon as we can. I have sent across v7 of rte_driver set. Unfortunately, I forgot to add your sign-off. If the set works for you, can you bulk ack? > >> >> Also, I have fixed most review comments except [1]. I am still not sure of >> the impact of this change. So, I will publish the v7 without this and then >> probably a v8 in case this change has any impact. > > I have no idea about this. Hopefully, it's not a very serious thing. > >> That way we can have your patchset not blocked because of this series. > > Thank you! > >> >> [1] http://dpdk.org/ml/archives/dev/2016-July/044004.html > >> >> [...] >> >> >> - >> Shreyansh > > >
