Re: [PATCH v2 01/10] app/test: make parameters clearer when adding fast tests

[Bruce Richardson]

On Fri, Dec 05, 2025 at 10:10:34AM +0000, Marat Khalili wrote:
> Apart from one cosmetic issue in a comment,
> 
> Acked-by: Marat Khalili <marat.khal...@huawei.com>
> 
> > diff --git a/app/test/suites/meson.build b/app/test/suites/meson.build
> > index 712dd65568..65995078b7 100644
> > --- a/app/test/suites/meson.build
> > +++ b/app/test/suites/meson.build
> > @@ -67,9 +67,19 @@ foreach suite:test_suites
> >          # special fast-test handling here
> >          foreach t: suite_tests
> >              params = t.split(':')
> > +            # check for valid options for asan and nohuge. Note, the 
> > extraction script runs tolower()
> 
> > diff --git a/buildtools/get-test-suites.py b/buildtools/get-test-suites.py
> > index c3a99a862e..73f1d9c9e1 100644
> > --- a/buildtools/get-test-suites.py
> > +++ b/buildtools/get-test-suites.py
> > @@ -18,7 +18,7 @@ def get_fast_test_params(test_name, ln):
> >      "Extract the extra fast-test parameters from the line"
> >      (_, rest_of_line) = ln.split(test_name, 1)
> >      (_, nohuge, asan, _func) = rest_of_line.split(',', 3)
> > -    return f":{nohuge.strip().lower()}:{asan.strip().lower()}"
> > +    return f":{nohuge.strip()}:{asan.strip()}"
> 
> Is the Note above no longer relevant?
> 
Ooops, yes, good catch.