On Tue, Apr 26, 2016 at 4:24 AM, Jianfeng Tan <jianfeng.tan at intel.com> wrote:
> Issue: virtio's drv_flags are decided by devices types (modern vs legacy),
> and which kernel driver is used, and the negotiated features (especially
> VIRTIO_NET_STATUS) with backend, which makes it possible to multiple
> virtio devices have different versions of drv_flags, but this variable
> is currently shared by each virtio device.
>
> How to fix: dev_flags is a device-specific variable to store this info.
>
> Fixes: da978dfdc43 ("virtio: use port IO to get PCI resource")
>
> Reported-by: David Marchand <david.marchand at 6wind.com>
> Suggested-by: David Marchand <david.marchand at 6wind.com>
> Signed-off-by: Jianfeng Tan <jianfeng.tan at intel.com>- ethdev dev_flags is supposed to be filled with RTE_ETH_DEV_DETACHABLE, RTE_ETH_DEV_INTR_LSC etc... not pci macros. - I would have kept the init code as it is until the rte_eth_copy_pci_info() step, then sanitise the dev_flags, but this might be a matter of taste. -- David Marchand
