On 2016/04/26 12:47, Yuanhan Liu wrote: > On Mon, Apr 25, 2016 at 12:28:37PM +0300, Panu Matilainen wrote: > > >>> Another way is applying a below patch. >>> --- a/drivers/net/vhost/Makefile >>> +++ b/drivers/net/vhost/Makefile >>> @@ -38,6 +38,7 @@ LIB = librte_pmd_vhost.a >>> >>> CFLAGS += -O3 >>> CFLAGS += $(WERROR_FLAGS) >>> +LDLIBS += -lrte_vhost >>> >>> EXPORT_MAP := rte_pmd_vhost_version.map >>> >>> This is same way to link libpcap to librte_pmd_pcap. >>> What do you think about adding it to vhost PMD? >> Yes, this is absolutely the right thing to do. >> >> Ultimately this should be done for all dependencies in all libraries, but >> missing dependencies are even more pronounced in plugins so the sooner this >> goes in, the better. >> >> Acked-by: Panu Matilainen <pmatilai at redhat.com> > Panu, thanks for the input. > > Tetsuya, please submit a formal patch so that I can merge. > > --yliu
Hi Yuanhan, Oh sorry, I forgot to add "--in-reply-to" while sending the patch, so you may miss it. Also the order of Acked-by and Signed-off-by was wrong in above patch. So I will send v2 soon. Thanks, Tetsuya
