> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, April 11, 2016 5:27 PM > To: Liu, Yong > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] examples/vm_power_manager: fix build > with libvirt version < 0.9.3 > > 2016-04-11 16:50, Marvin Liu: > > Fixes: 2e099bc5d104 ("fix split of compiler and linker options") > > As commented earlier, I don't think it is the origin of the issue. > Yes, this issue existed from the original. 2e099bc5d104 is the first buildable version. I will change commit to original version.
> > +$(info "vm_power_manager required libvirt version >= 0.9.3, please > update libvirt-devel first") > > "required" should be "requires". > libvirt-devel is the name of the package on some distributions, but > it is not always the case. Moreover, the whole libvirt package must be > updated atomically, not only the headers. That's why I think it's better > to remove this part and just keep: > "vm_power_manager requires libvirt version >= 0.9.3" > > Other issue: it would better to use $(error to generate a compilation > error. > But the example should not be skipped from examples/Makefile in this case. Thanks, will generate error when libvirt not meet requirement.
