On Sat, 7 Jun 2025 10:30:20 +0800
Junlong Wang <wang.junlo...@zte.com.cn> wrote:
> modify rss related issues in testing process.
Better commit message please. Should have Fixes: tabg.
>
> Signed-off-by: Junlong Wang <wang.junlo...@zte.com.cn>
> ---
> drivers/net/zxdh/zxdh_ethdev.c | 1 +
> drivers/net/zxdh/zxdh_ethdev_ops.c | 66 +++++++++++++++++++-----------
> drivers/net/zxdh/zxdh_ethdev_ops.h | 4 +-
> drivers/net/zxdh/zxdh_msg.c | 12 +++---
> drivers/net/zxdh/zxdh_tables.c | 8 ++--
> 5 files changed, 54 insertions(+), 37 deletions(-)
>
> diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_ethdev.c
> index 9512aff99c..a245ab24ce 100644
> --- a/drivers/net/zxdh/zxdh_ethdev.c
> +++ b/drivers/net/zxdh/zxdh_ethdev.c
> @@ -66,6 +66,7 @@ zxdh_dev_infos_get(struct rte_eth_dev *dev,
> dev_info->rx_offload_capa |= RTE_ETH_RX_OFFLOAD_TCP_LRO;
> dev_info->rx_offload_capa |= RTE_ETH_RX_OFFLOAD_RSS_HASH;
>
> + dev_info->hash_key_size = ZXDH_RSS_HASH_KEY_LEN;
> dev_info->reta_size = RTE_ETH_RSS_RETA_SIZE_256;
> dev_info->flow_type_rss_offloads = ZXDH_RSS_HF;
>
> diff --git a/drivers/net/zxdh/zxdh_ethdev_ops.c
> b/drivers/net/zxdh/zxdh_ethdev_ops.c
> index c16271aeaf..86517d571a 100644
> --- a/drivers/net/zxdh/zxdh_ethdev_ops.c
> +++ b/drivers/net/zxdh/zxdh_ethdev_ops.c
> @@ -289,7 +289,7 @@ zxdh_link_info_get(struct rte_eth_dev *dev, struct
> rte_eth_link *link)
> zxdh_pci_read_dev_config(hw, offsetof(struct zxdh_net_config,
> status),
> &status, sizeof(status));
>
> - link->link_status = status;
> + link->link_status = status & hw->admin_status;
>
> if (status == RTE_ETH_LINK_DOWN) {
> link->link_speed = RTE_ETH_SPEED_NUM_UNKNOWN;
> @@ -1207,7 +1207,7 @@ zxdh_rss_hf_to_hw(uint64_t hf)
> }
>
> static uint64_t
> -zxdh_rss_hf_to_eth(uint32_t hw_hf)
> +zxdh_rss_hf_to_eth(uint64_t hw_hf)
> {
> uint64_t hf = 0;
>
> @@ -1245,7 +1245,7 @@ zxdh_rss_hash_update(struct rte_eth_dev *dev,
> hw_hf_new = zxdh_rss_hf_to_hw(rss_conf->rss_hf);
> hw_hf_old = zxdh_rss_hf_to_hw(old_rss_conf->rss_hf);
>
> - if ((hw_hf_new != hw_hf_old || !!rss_conf->rss_hf))
> + if ((hw_hf_new != hw_hf_old || hw->rss_enable != (!!rss_conf->rss_hf)))
You don't needs so many () here. Just:
if (hw_hf_new != hw_hf_old || hw->rss_enable != !!rss_conf->rss_hf)
