On Mon, May 05, 2025 at 07:45:36AM -0700, Andre Muezerie wrote: > When compiling DPDK with mlx5 using clang on Windows with > "debug" buildtype the error below is hit: > > net_mlx5_mlx5_flow_dv.c.obj : error LNK2019: unresolved external symbol > mlx5_geneve_tlv_parser_create referenced in function > flow_dv_discover_priorities > drivers\rte_net_mlx5-25.dll : fatal error LNK1120: 1 unresolved externals > > With a "release" buildtype the error is not seen, which explains why this > issue was not reported earlier. > > The same problem will show up with MSVC, but patches which are still under > review are needed for this to be hit with MSVC. > > The cause of this problem seems to be that mlx5_flow_geneve.c is only > compiled on Linux. This patch fixes the issue by compiling the file on all > operating systems. It also sorts the file names in meson.build in > alphabetical order. > > > REPRO STEPS (On Windows) > > set DEVX_INC_PATH=V:\soft\MLNX_WinOF2_DevX_SDK\inc > set DEVX_LIB_PATH=V:\soft\MLNX_WinOF2_DevX_SDK\lib > set CFLAGS=-I"%DEVX_INC_PATH%" > set LDFLAGS=-Wl,-LIBPATH:"%DEVX_LIB_PATH%" > set CC=clang > meson setup -Dexamples=helloworld build --buildtype debug > ninja -C build > > > Andre Muezerie (1): > net/mlx5: unresolved symbol mlx5_geneve_tlv_parser_create > > drivers/net/mlx5/meson.build | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > -- > 2.49.0.vfs.0.0
Would someone be able to review this patchset? Thanks, Andre Muezerie
