> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Rasesh Mody > Subject: [dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get
Hi Rasesh, > + snprintf(xstats[num].name, sizeof(xstats[num].name), "brb_drops"); I don't understand what a "brb" drop is. > + snprintf(xstats[num].name, sizeof(xstats[num].name), "tx_pfc"); Similarly here, and with some other of the xstats strings, it doesn't become clear to me what exactly the value represents. "mac_filter_discard" is descriptive and readable, but the next stat has "mf_tag_discard" - these small inconsistencies make it much harder (impossible?) to scrap the xstats strings and retrieve useful metadata. I'll suggest leaving the xstats implementation part of this patch until the next release, and we can align on the names of the stats. -Harry
