On Thu, May 15, 2025 at 01:39:47PM +0200, David Marchand wrote:
> On Thu, May 15, 2025 at 11:37 AM Bruce Richardson
> <bruce.richard...@intel.com> wrote:
> >
> > On Thu, May 15, 2025 at 09:09:22AM +0200, David Marchand wrote:
> > > On Tue, May 13, 2025 at 11:00 AM Bruce Richardson
> > > <bruce.richard...@intel.com> wrote:
> > > >
> > > > Add a script to buildtools to report the minimum meson version given in
> > > > our meson.build file. Then use this script in two ways:
> > > >
> > > > 1. in the .ci/linux-setup.sh script, use the auto-determined minimum
> > > >    version to set up the CI, rather than hard-coding it.
> > > > 2. in meson.build call the script to report the version. This serves as
> > > >    a sanity check to ensure that any changes to meson.build file do not
> > > >    break the script.
> > > >
> > > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
> > > > Acked-by: Stephen Hemminger <step...@networkplumber.org>
> > > > Reviewed-by: Patrick Robb <pr...@iol.unh.edu>
> > > > ---
> > > > v2: rebased to latest main
> > >
> > > This patch is reverting dbcd72f3fba0 ("ci: fix unit tests with Fedora 
> > > 37").
> > >
> > > There were some strange errors raised by UNH, though I don't see the
> > > same python backtrace.
> > > Let's try again:
> > > Recheck-request: iol-unit-arm64-testing, iol-unit-amd64-testing
> > >
> > If we have issues using 0.57, I don't see there being issues with us
> > marking the min meson version to 0.57.2 rather than 0.57 alone. I can do
> > that in a v3, or else we can abandon this patch, if you prefer.
> 
> Retests show the same error, so I think we are hitting the issue fixed
> with dbcd72f3fba0.
> 
> Bumping the minimal version to 0.57.2 seems fine.
> I looked and can't find a distrib that ships meson 0.57.
> So either a user relies on the distrib version (with a version >=
> 0.58, from my quick search) or the distrib provided version is too old
> and then the user relies on pip.
> 
Ok, will do a new revision with the version bump.

/Bruce

Reply via email to