On 11.04.2025 22:39, Andre Muezerie wrote:
buildtools/meson.build was updated to require Python module "pefile" on
Windows. This module is used to parse symbols on Windows images. Windows
images are in PE format (opposed to ELF on Linux).
It is not used on build stage and thus is not needed.
There is no documentation on `dpdk-pmdinfo` requirements
in `doc/guides/tools/pmdinfo.rst` or `guides/linux_gsg/sys_reqs.rst`,
so you can either just drop this part or document requirements in patch 3/4.
diff --git a/buildtools/gen-pmdinfo-cfile.py b/buildtools/gen-pmdinfo-cfile.py
index 5fbd51658a..9b4c2c48f8 100644
--- a/buildtools/gen-pmdinfo-cfile.py
+++ b/buildtools/gen-pmdinfo-cfile.py
@@ -10,7 +10,11 @@
_, tmp_root, ar, archive, output, *pmdinfogen = sys.argv
with tempfile.TemporaryDirectory(dir=tmp_root) as temp:
paths = []
- for name in subprocess.run([ar, "t", archive], stdout=subprocess.PIPE,
+ if ar == 'lib':
+ ar_options = ['/LIST', '/NOLOGO']
+ else:
+ ar_options = ['t']
+ for name in subprocess.run([ar] + ar_options + [archive],
stdout=subprocess.PIPE,
check=True).stdout.decode().splitlines():
Nit: I suggest renaming 'ar' to 'archiver' to avoid confusion with
specifically 'ar'.
Previously this variable could only refer to 'ar' flavors.
