RE: [EXTERNAL] [PATCH] net/netvsc: add stats counters from VF

[Long Li]

> > > Subject: [EXTERNAL] [PATCH] net/netvsc: add stats counters from VF
> > >
> > > From: Long Li <lon...@microsoft.com>
> > >
> > > The netvsc driver should add per-queue and rx_nombuf counters from VF.
> > >
> > > Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
> > > Cc: sta...@dpdk.org
> > > Signed-off-by: Long Li <lon...@microsoft.com>
> > > ---
> > >  drivers/net/netvsc/hn_ethdev.c | 10 +++++-----
> > >  1 file changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/drivers/net/netvsc/hn_ethdev.c
> > > b/drivers/net/netvsc/hn_ethdev.c index 988c51928d..069d603d90 100644
> > > --- a/drivers/net/netvsc/hn_ethdev.c
> > > +++ b/drivers/net/netvsc/hn_ethdev.c
> > > @@ -824,8 +824,8 @@ static int hn_dev_stats_get(struct rte_eth_dev *dev,
> > >           stats->oerrors += txq->stats.errors;
> > >
> > >           if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
> > > -                 stats->q_opackets[i] = txq->stats.packets;
> > > -                 stats->q_obytes[i] = txq->stats.bytes;
> > > +                 stats->q_opackets[i] += txq->stats.packets;
> > > +                 stats->q_obytes[i] += txq->stats.bytes;
> > >           }
> > >   }
> > >
> > > @@ -841,12 +841,12 @@ static int hn_dev_stats_get(struct rte_eth_dev
> > > *dev,
> > >           stats->imissed += rxq->stats.ring_full;
> > >
> > >           if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
> > > -                 stats->q_ipackets[i] = rxq->stats.packets;
> > > -                 stats->q_ibytes[i] = rxq->stats.bytes;
> > > +                 stats->q_ipackets[i] += rxq->stats.packets;
> > > +                 stats->q_ibytes[i] += rxq->stats.bytes;
> > >           }
> > >   }
> > >
> > > - stats->rx_nombuf = dev->data->rx_mbuf_alloc_failed;
> > > + stats->rx_nombuf += dev->data->rx_mbuf_alloc_failed;
> > >   return 0;
> > >  }
> > >
> > > --
> > > 2.34.1
> >
> > Reviewed-by: Wei Hu <w...@linux.microsoft.com>
> 
> Hi Stephen,
> 
> Is it okay to merge this patch?
> 
> Thanks,
> Long

Hi Stephen,

Ping again.

Let me know if you want me to rebase (but it seems it should be a straight 
apply) and send v2.

Thanks,

Long