02/04/2025 09:00, David Marchand: > On Tue, Apr 1, 2025 at 10:25 PM Thomas Monjalon <tho...@monjalon.net> wrote: > > > > 28/03/2025 11:52, David Marchand: > > > Rather than maintain a file in parallel of the code, symbols to be > > > exported can be marked with a token RTE_EXPORT_*SYMBOL. > > > > > > From those marks, the build framework generates map files only for > > > symbols actually compiled (which means that the WINDOWS_NO_EXPORT hack > > > becomes unnecessary). > > > > > > The build framework directly creates a map file in the format that the > > > linker expects (rather than converting from GNU linker to MSVC linker). > > > > At this point of the series, the build is broken. > > I suppose it is a tradeoff to avoid squashing 2 big patches together. > > > > This is the error I hit: > > drivers/meson.build:275:37: ERROR: Unknown variable "sources_avx2". > > Hum, I'll have to reproduce. > I had tested patch per patch in previous revisions, but I have a doubt > after the rebase on top of Bruce series..
Yes my bad, it works after pulling Bruce's rework.
