19/03/2025 17:31, David Marchand: > On Wed, Mar 5, 2025 at 5:25 PM Bruce Richardson > <bruce.richard...@intel.com> wrote: > > > > In cases where the number of cores on a given socket is greater than > > RTE_MAX_LCORES, then EAL will be unaware of all the sockets/numa nodes > > on a system. Fix this limitation by having the EAL probe the NUMA node > > for cores it isn't going to use, and recording that for completeness. > > > > This is necessary as memory is tracked per node, and with the --lcores > > parameters our app lcores may be on different sockets than the lcore ids > > may imply. For example, lcore 0 is on socket zero, but if app is run > > with --lcores=0@64, then DPDK lcore 0 may be on socket one, so DPDK > > needs to be aware of that socket. > > > > Fixes: 952b20777255 ("eal: provide API for querying valid socket ids") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > > On the principle, the fix lgtm.
It is very late in the release cycle, but we have discussed it and decided to merge this fix in 25.03. Applied, thanks.