[PATCH v8 10/17] crypto/qat: fix size calculation for memset

[Stephen Hemminger]

The memset was always doing 0 bytes since size computed later.

Link: https://pvs-studio.com/en/blog/posts/cpp/1179/

Fixes: 3a80d7fb2ecd ("crypto/qat: support SHA3 plain hash")
Cc: sta...@dpdk.org

Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
Acked-by: Bruce Richardson <bruce.richard...@intel.com>
---
 drivers/crypto/qat/qat_sym_session.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/crypto/qat/qat_sym_session.c 
b/drivers/crypto/qat/qat_sym_session.c
index 3564a33484..7836c95064 100644
--- a/drivers/crypto/qat/qat_sym_session.c
+++ b/drivers/crypto/qat/qat_sym_session.c
@@ -2347,7 +2347,7 @@ int qat_sym_cd_cipher_set(struct qat_sym_session *cdesc,
        return 0;
 }
 
-int qat_sym_cd_auth_set(struct qat_sym_session *cdesc,
+static int qat_sym_cd_auth_set(struct qat_sym_session *cdesc,
                const uint8_t *authkey,
                uint32_t authkeylen,
                uint32_t aad_length,
@@ -2620,27 +2620,27 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc,
                break;
        case ICP_QAT_HW_AUTH_ALGO_SHA3_224:
                /* Plain SHA3-224 */
-               memset(cdesc->cd_cur_ptr, 0, state1_size);
                state1_size = qat_hash_get_state1_size(
                                cdesc->qat_hash_alg);
+               memset(cdesc->cd_cur_ptr, 0, state1_size);
                break;
        case ICP_QAT_HW_AUTH_ALGO_SHA3_256:
                /* Plain SHA3-256 */
-               memset(cdesc->cd_cur_ptr, 0, state1_size);
                state1_size = qat_hash_get_state1_size(
                                cdesc->qat_hash_alg);
+               memset(cdesc->cd_cur_ptr, 0, state1_size);
                break;
        case ICP_QAT_HW_AUTH_ALGO_SHA3_384:
                /* Plain SHA3-384 */
-               memset(cdesc->cd_cur_ptr, 0, state1_size);
                state1_size = qat_hash_get_state1_size(
                                cdesc->qat_hash_alg);
+               memset(cdesc->cd_cur_ptr, 0, state1_size);
                break;
        case ICP_QAT_HW_AUTH_ALGO_SHA3_512:
                /* Plain SHA3-512 */
-               memset(cdesc->cd_cur_ptr, 0, state1_size);
                state1_size = qat_hash_get_state1_size(
                                cdesc->qat_hash_alg);
+               memset(cdesc->cd_cur_ptr, 0, state1_size);
                break;
        case ICP_QAT_HW_AUTH_ALGO_AES_XCBC_MAC:
                state1_size = ICP_QAT_HW_AES_XCBC_MAC_STATE1_SZ;
-- 
2.47.2