On Fri, Feb 07, 2025 at 02:12:27PM +0100, Burakov, Anatoly wrote: > On 07/02/2025 14:04, Bruce Richardson wrote: > > On Fri, Feb 07, 2025 at 12:44:59PM +0000, Anatoly Burakov wrote: > > > From: Vitaly Lifshits <vitaly.lifsh...@intel.com> > > > > > > Add support for new hardware ID's from the I219 series. > > > > > > Signed-off-by: Vitaly Lifshits <vitaly.lifsh...@intel.com> > > > Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com> > > > --- > > > > Should i219 be added to the base code README as a supported device family? > > If so, I can just add on apply, if no other issues with this set. > > i219 NICs were already supported by the driver. This is just adding missing > *kinds* of i219 NICs. However, I can see that the support for i219 was > called out in 17.02 release notes: > > 31d4210971c54952afc9a1455ca40861634206e0 > net/e1000/base: announce supported devices > > Document all supported NICs. > Add Intel I219 NICs support in release note. > > Signed-off-by: Wenzhuo Lu <wenzhuo...@intel.com> > > It was not added to the list of supported NICs in igb documentation. So, > yes, I think it is worth calling out support in this patch. >
For i219, I see that it is actually in the list of devices given in the REAME, with the list in that doc not being in sorted order, but more in order of which sub-driver (e1000, igb and igc) supports them. The original e1000 driver is the one supporting i219, so it's earlier in the list, which is why I missed it. For other docs, the e1000 driver guide doesn't call out the various families of HW NICs supported, so no minor update needed there either it seem. I'll therefore take this patch as-is. /Bruce
