> From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > Sent: Thursday, 30 January 2025 22.55 > > As per guidance technical board meeting 2024/04/17. This series > removes the use of VLAs from code built for Windows for all 3 > toolchains. If there are additional opportunities to convert VLAs > to regular C arrays please provide the details for incorporation > into the series. > > MSVC does not support VLAs, replace VLAs with standard C arrays > or alloca(). alloca() is available for all toolchain/platform > combinations officially supported by DPDK. > > v18: > * add no_vla_cflag to examples directories that are not VLA-free > * add no_vla_cflag to drivers directories that are not VLA-free and > were missed in v17 due to missing libs > > v17: > * define no_vla_cflag in a top directory (config) > * add no_vla_cflag to directories that are not VLA-free > * add -Wvla project-wide (VLAs not allowed by default, except for > directories using no_vla_cflag)
nit: The name no_vla_cflag is inverted. It should be e.g. no_wvla_cflag or allow_vla_cflag. Although the latter lacks indication that it is an exception, it could be mentioned in a comment where it is defined. Maybe no_wvla_cflag is better.
