> From: Andre Muezerie [mailto:[email protected]] > Sent: Monday, 27 January 2025 17.04 > > MSVC issues the warnings below: > > 1) ../lib/hash/rte_thash_gf2_poly_math.c(128): warning C4334: '<<': > result of 32-bit shift implicitly converted to 64 bits > (was 64-bit shift intended?) > > The code would be better off by using 64 bit numbers to begin with. > That eliminates the need for a conversion to 64 bits later. > > 2) ../lib/hash/rte_thash.c(568): warning C4334: '<<': > result of 32-bit shift implicitly converted to 64 bits > (was 64-bit shift intended?) > > Instead of multiplying sizeof(uint32_t) by the result of shifting > "1", sizeof(uint32_t) can be shifted directly. > > Signed-off-by: Andre Muezerie <[email protected]> > Acked-by: Vladimir Medvedkin <[email protected]> > Acked-by: Bruce Richardson <[email protected]> > ---
Reviewed-by: Morten Brørup <[email protected]>
