[PATCH 2/2] dmadev: avoid copies in tracepoints

[David Marchand]

No need to copy values in intermediate variables.
Just use the right trace point emitters.

Signed-off-by: David Marchand <david.march...@redhat.com>
---
 lib/dmadev/rte_dmadev_trace.h    | 20 ++++++--------------
 lib/dmadev/rte_dmadev_trace_fp.h | 12 ++++--------
 2 files changed, 10 insertions(+), 22 deletions(-)

diff --git a/lib/dmadev/rte_dmadev_trace.h b/lib/dmadev/rte_dmadev_trace.h
index be089c065c..ddf60b9649 100644
--- a/lib/dmadev/rte_dmadev_trace.h
+++ b/lib/dmadev/rte_dmadev_trace.h
@@ -46,11 +46,10 @@ RTE_TRACE_POINT(
        const struct rte_dma_conf __dev_conf = {0};
        dev_conf = &__dev_conf;
 #endif /* _RTE_TRACE_POINT_REGISTER_H_ */
-       int enable_silent = (int)dev_conf->enable_silent;
        rte_trace_point_emit_i16(dev_id);
        rte_trace_point_emit_u16(dev_conf->nb_vchans);
        rte_trace_point_emit_u16(dev_conf->priority);
-       rte_trace_point_emit_int(enable_silent);
+       rte_trace_point_emit_u8(dev_conf->enable_silent);
        rte_trace_point_emit_int(ret);
 )
 
@@ -83,21 +82,14 @@ RTE_TRACE_POINT(
        const struct rte_dma_vchan_conf __conf = {0};
        conf = &__conf;
 #endif /* _RTE_TRACE_POINT_REGISTER_H_ */
-       int src_port_type = conf->src_port.port_type;
-       int dst_port_type = conf->dst_port.port_type;
-       int direction = conf->direction;
-       uint64_t src_pcie_cfg;
-       uint64_t dst_pcie_cfg;
        rte_trace_point_emit_i16(dev_id);
        rte_trace_point_emit_u16(vchan);
-       rte_trace_point_emit_int(direction);
+       rte_trace_point_emit_int(conf->direction);
        rte_trace_point_emit_u16(conf->nb_desc);
-       rte_trace_point_emit_int(src_port_type);
-       memcpy(&src_pcie_cfg, &conf->src_port.pcie, sizeof(uint64_t));
-       rte_trace_point_emit_u64(src_pcie_cfg);
-       memcpy(&dst_pcie_cfg, &conf->dst_port.pcie, sizeof(uint64_t));
-       rte_trace_point_emit_int(dst_port_type);
-       rte_trace_point_emit_u64(dst_pcie_cfg);
+       rte_trace_point_emit_int(conf->src_port.port_type);
+       rte_trace_point_emit_blob(&conf->src_port.pcie, sizeof(uint64_t));
+       rte_trace_point_emit_int(conf->dst_port.port_type);
+       rte_trace_point_emit_blob(&conf->dst_port.pcie, sizeof(uint64_t));
        rte_trace_point_emit_ptr(conf->auto_free.m2d.pool);
        rte_trace_point_emit_int(ret);
 )
diff --git a/lib/dmadev/rte_dmadev_trace_fp.h b/lib/dmadev/rte_dmadev_trace_fp.h
index f5b96838bc..4950f58cd2 100644
--- a/lib/dmadev/rte_dmadev_trace_fp.h
+++ b/lib/dmadev/rte_dmadev_trace_fp.h
@@ -37,10 +37,9 @@ RTE_TRACE_POINT_FP(
        enum rte_dma_vchan_status __status = 0;
        status = &__status;
 #endif /* _RTE_TRACE_POINT_REGISTER_H_ */
-       int vchan_status = *status;
        rte_trace_point_emit_i16(dev_id);
        rte_trace_point_emit_u16(vchan);
-       rte_trace_point_emit_int(vchan_status);
+       rte_trace_point_emit_int(*status);
        rte_trace_point_emit_int(ret);
 )
 
@@ -107,13 +106,11 @@ RTE_TRACE_POINT_FP(
        last_idx = &__last_idx;
        has_error = &__has_error;
 #endif /* _RTE_TRACE_POINT_REGISTER_H_ */
-       int has_error_val = *has_error;
-       int last_idx_val = *last_idx;
        rte_trace_point_emit_i16(dev_id);
        rte_trace_point_emit_u16(vchan);
        rte_trace_point_emit_u16(nb_cpls);
-       rte_trace_point_emit_int(last_idx_val);
-       rte_trace_point_emit_int(has_error_val);
+       rte_trace_point_emit_u16(*last_idx);
+       rte_trace_point_emit_u8(*has_error);
        rte_trace_point_emit_u16(ret);
 )
 
@@ -126,11 +123,10 @@ RTE_TRACE_POINT_FP(
        uint16_t __last_idx = 0;
        last_idx = &__last_idx;
 #endif /* _RTE_TRACE_POINT_REGISTER_H_ */
-       int last_idx_val = *last_idx;
        rte_trace_point_emit_i16(dev_id);
        rte_trace_point_emit_u16(vchan);
        rte_trace_point_emit_u16(nb_cpls);
-       rte_trace_point_emit_int(last_idx_val);
+       rte_trace_point_emit_u16(*last_idx);
        rte_trace_point_emit_ptr(status);
        rte_trace_point_emit_u16(ret);
 )
-- 
2.47.1