On Fri, Jan 24, 2025 at 09:43:03AM +0100, David Marchand wrote: > On Mon, Jan 20, 2025 at 1:00 PM Bruce Richardson > <bruce.richard...@intel.com> wrote: > > > > This patchset attempts to reduce the amount of code duplication across a > > number of Intel NIC drivers, specifically: ixgbe, i40e, iavf, and ice. > > As part of this process of deduplication, and in preparation for further > > cleanup work, it moves all existing Intel drivers to a net/intel > > directory, with a "common" subdirectory being created there for the code > > shared between drivers. > > > > The first deduplication patch extracts a function from the Rx side, > > otherwise the majority of the changes are on the Tx side, leading to a > > converged Tx queue structure across the 4 drivers, and a large number of > > common functions. > > 394 files changed, 1495 insertions(+), 2510 deletions(-) > I like this kind of series the most. >
Thanks, I was keen to hit the 1k lines saving. > I did not enter into the (ugly?) details, but overall it seems good. > Thanks for working on this Bruce. > I'm hoping this is only the start, there are plenty of other opportunities to reduce code duplication, but I didn't want the patchset to be too big, and I also wanted to avoid having too much scope for breaking things. I'll try and get v6 out today. Thanks for the review, and the suggested tooling changes. /Bruce > > -- > David Marchand >
