After discussion[1], the drivers do not include the CRC in the packet length calculation. This will cause users to be confused about whether the mbuf contains CRC data. This patch adds a packet offload Rx flag, indicating that CRC data exists at the end of the mbuf chain.
[1] https://inbox.dpdk.org/dev/20240206011030.2007689-1-haij...@huawei.com/ Signed-off-by: Dengdui Huang <huangdeng...@huawei.com> --- lib/mbuf/rte_mbuf.c | 3 ++- lib/mbuf/rte_mbuf_core.h | 8 +++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/mbuf/rte_mbuf.c b/lib/mbuf/rte_mbuf.c index 559d5ad8a7..c828200ea1 100644 --- a/lib/mbuf/rte_mbuf.c +++ b/lib/mbuf/rte_mbuf.c @@ -771,7 +771,7 @@ const char *rte_get_rx_ol_flag_name(uint64_t mask) case RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD: return "RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD"; case RTE_MBUF_F_RX_OUTER_L4_CKSUM_INVALID: return "RTE_MBUF_F_RX_OUTER_L4_CKSUM_INVALID"; - + case RTE_MBUF_F_RX_KEEP_CRC: return "RTE_MBUF_F_RX_KEEP_CRC"; default: return NULL; } } @@ -818,6 +818,7 @@ rte_get_rx_ol_flag_list(uint64_t mask, char *buf, size_t buflen) NULL }, { RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN, RTE_MBUF_F_RX_OUTER_L4_CKSUM_MASK, "RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN" }, + { RTE_MBUF_F_RX_KEEP_CRC, RTE_MBUF_F_RX_KEEP_CRC, NULL }, }; const char *name; unsigned int i; diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h index a0df265b5d..0c57b929b7 100644 --- a/lib/mbuf/rte_mbuf_core.h +++ b/lib/mbuf/rte_mbuf_core.h @@ -180,9 +180,15 @@ extern "C" { #define RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD (1ULL << 22) #define RTE_MBUF_F_RX_OUTER_L4_CKSUM_INVALID ((1ULL << 21) | (1ULL << 22)) +/** + * Indicates that there is CRC data at the end of the mbuf chain. + * Note: pkt_len and date_len fields are not adjusted for CRC data. + */ +#define RTE_MBUF_F_RX_KEEP_CRC (1ULL << 23) + /* add new RX flags here, don't forget to update RTE_MBUF_F_FIRST_FREE */ -#define RTE_MBUF_F_FIRST_FREE (1ULL << 23) +#define RTE_MBUF_F_FIRST_FREE (1ULL << 24) #define RTE_MBUF_F_LAST_FREE (1ULL << 40) /* add new TX flags here, don't forget to update RTE_MBUF_F_LAST_FREE */ -- 2.33.0
