Hello,
This series addresses Bugzilla ID 1586; the man says
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Meaning, the check around around pthread_mutex_init() is needless.
```
$ git grep -Pn '=\s?pthread_mutex_init\('
drivers/common/cnxk/roc_bphy_cgx.c:197: ret =
pthread_mutex_init(&roc_cgx->lock, NULL);
drivers/net/bnxt/bnxt_ethdev.c:5826: err =
pthread_mutex_init(&bp->flow_lock, NULL);
drivers/net/bnxt/bnxt_ethdev.c:5832: err =
pthread_mutex_init(&bp->def_cp_lock, NULL);
drivers/net/bnxt/bnxt_ethdev.c:5838: err =
pthread_mutex_init(&bp->health_check_lock, NULL);
drivers/net/bnxt/bnxt_ethdev.c:5844: err =
pthread_mutex_init(&bp->err_recovery_lock, NULL);
drivers/net/bnxt/bnxt_ethdev.c:6773: rc =
pthread_mutex_init(&bp->rep_info->vfr_start_lock, NULL);
drivers/net/bnxt/bnxt_txq.c:201: rc = pthread_mutex_init(&txq->txq_lock,
NULL);
drivers/net/bnxt/tf_ulp/bnxt_ulp.c:218: rc =
pthread_mutex_init(&session->bnxt_ulp_mutex, NULL);
drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c:1475: rc =
pthread_mutex_init(&bp->ulp_ctx->cfg_data->flow_db_lock, NULL);
drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c:996: rc =
pthread_mutex_init(&bp->ulp_ctx->cfg_data->flow_db_lock, NULL);
drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c:132: rc =
pthread_mutex_init(&ulp_fc_info->fc_lock, NULL);
drivers/net/bnxt/tf_ulp/ulp_ha_mgr.c:415: rc =
pthread_mutex_init(&ha_info->ha_lock, NULL);
drivers/net/failsafe/failsafe.c:150: ret =
pthread_mutex_init(&priv->hotplug_mutex, &attr);
drivers/net/hinic/base/hinic_compat.h:205: err =
pthread_mutex_init(pthreadmutex, mattr);
drivers/raw/ifpga/base/opae_intel_max10.c:1489: ret =
pthread_mutex_init(&dev->bmc_ops.lock, NULL);
drivers/raw/ifpga/base/opae_spi_transaction.c:510: ret =
pthread_mutex_init(&spi_tran_dev->lock, NULL);
lib/vhost/socket.c:501: ret = pthread_mutex_init(&reconn_list.mutex, NULL);
lib/vhost/socket.c:924: ret = pthread_mutex_init(&vsocket->conn_mutex, NULL);
```
Thank you,
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Series-Acked-by: Stephen Hemminger <step...@networkplumber.org>
---
v4
* addressed feedback, turned returns into tail calls
* reworded the cover letter
v3 (https://inbox.dpdk.org/dev/20250112202021.179634-1-otili...@eurecom.fr/)
* fix style issues
v2 (https://inbox.dpdk.org/dev/20250112193043.67372-1-otili...@eurecom.fr/)
* fix build issues
v1 (https://inbox.dpdk.org/dev/20250112185842.9752-1-otili...@eurecom.fr/#t)
Ariel Otilibili (6):
raw/ifpga: remove check around pthread_mutex_init()
net/bnxt: remove check around pthread_mutex_init()
common/cnxk: remove check around pthread_mutex_init()
net/failsafe: remove check around pthread_mutex_init()
net/hinic: remove check around pthread_mutex_init()
lib/vhost: remove check around pthread_mutex_init()
drivers/common/cnxk/roc_bphy_cgx.c | 5 +--
drivers/net/bnxt/bnxt_ethdev.c | 40 ++++---------------
drivers/net/bnxt/bnxt_txq.c | 7 +---
drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 8 +---
drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c | 6 +--
drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c | 6 +--
drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c | 6 +--
drivers/net/bnxt/tf_ulp/ulp_ha_mgr.c | 6 +--
drivers/net/failsafe/failsafe.c | 8 +---
drivers/net/hinic/base/hinic_compat.h | 8 +---
drivers/raw/ifpga/base/opae_intel_max10.c | 5 +--
drivers/raw/ifpga/base/opae_spi_transaction.c | 7 +---
lib/vhost/socket.c | 14 +------
13 files changed, 21 insertions(+), 105 deletions(-)
--
2.30.2
