Re: [PATCH v3 5/6] net/hinic: remove check around pthread_mutex_init()

[Stephen Hemminger]

On Sun, 12 Jan 2025 21:20:20 +0100
Ariel Otilibili <otili...@eurecom.fr> wrote:

> diff --git a/drivers/net/hinic/base/hinic_compat.h 
> b/drivers/net/hinic/base/hinic_compat.h
> index ab9d1b9a0214..8f5763fbfc9d 100644
> --- a/drivers/net/hinic/base/hinic_compat.h
> +++ b/drivers/net/hinic/base/hinic_compat.h
> @@ -200,13 +200,9 @@ static inline u16 ilog2(u32 n)
>  static inline int hinic_mutex_init(pthread_mutex_t *pthreadmutex,
>                                       const pthread_mutexattr_t *mattr)
>  {
> -     int err;
> -
> -     err = pthread_mutex_init(pthreadmutex, mattr);
> -     if (unlikely(err))
> -             PMD_DRV_LOG(ERR, "Fail to initialize mutex, error: %d", err);
> +     pthread_mutex_init(pthreadmutex, mattr);
>  
> -     return err;
> +     return 0;
>  }

Could be a tail call here, if you want.
        return pthread_mutex_init(pthradmutex, mattr);