On Tue, Dec 31, 2024 at 7:38 PM Andre Muezerie <andre...@linux.microsoft.com> wrote: > diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h > index 4d299f2b36..40592f71b1 100644 > --- a/lib/eal/include/rte_common.h > +++ b/lib/eal/include/rte_common.h > @@ -99,13 +99,32 @@ typedef uint32_t unaligned_uint32_t; > typedef uint16_t unaligned_uint16_t; > #endif > > +/** > + * @deprecated > + * @see __rte_packed_begin > + * @see __rte_packed_end > + * > + * Force a structure to be packed > + */ > +#ifdef RTE_TOOLCHAIN_MSVC > +#define __rte_packed RTE_DEPRECATED(__rte_packed) > +#else > +#define __rte_packed (RTE_DEPRECATED(__rte_packed) > __attribute__((__packed__))) > +#endif > +
We can't mark __rte_packed as deprecated so "early" in the series. Instead, this must be moved as a last patch, to avoid breaking compilations in the middle of the series. -- David Marchand