On Mon, Jan 06, 2025 at 10:54:43AM +0000, Bruce Richardson wrote: > On Thu, Dec 26, 2024 at 12:59:30PM -0800, Andre Muezerie wrote: > > This patch avoids warnings like the ones below emitted by MSVC: > > > > 1) > > ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<': > > result of 32-bit shift implicitly converted to 64 bits > > (was 64-bit shift intended?) > > > > 2) > > ../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=': > > signed/unsigned mismatch > > > > The fix for (1) is to use 64-bit shifting when appropriate > > (according to what the result is used for). > > > > The fix for (2) is to explicitly cast the variables used in the > > comparison. > > > > Signed-off-by: Andre Muezerie <andre...@linux.microsoft.com> > > --- > > drivers/net/i40e/i40e_ethdev.c | 22 +++++++++++----------- > > drivers/net/iavf/iavf_ethdev.c | 2 +- > > drivers/net/iavf/iavf_rxtx.c | 2 +- > > drivers/net/iavf/iavf_vchnl.c | 2 +- > > drivers/net/ice/base/ice_flg_rd.c | 4 ++-- > > drivers/net/ice/base/ice_parser_rt.c | 16 ++++++++-------- > > drivers/net/ice/base/ice_xlt_kb.c | 2 +- > > drivers/net/ice/ice_dcf_sched.c | 2 +- > > drivers/net/ice/ice_ethdev.c | 4 ++-- > > drivers/net/ice/ice_rxtx.c | 2 +- > > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- > > Most of these changes to the intel drivers look fine to me. However, for > the base code files, we try to avoid modifying those as they come from a > common, shared internal source which we regularly sync with. Therefore, for > the 3 base files, can the errors/warning be suppressed instead? > > Regards, > /Bruce
I wasn't aware of that. Thanks for letting me know. I'll make the modifications suggested in v2 of this series.
