On Thu, Jan 02, 2025 at 04:15:31PM -0800, Andre Muezerie wrote: > On Thu, Jan 02, 2025 at 03:51:55PM -0800, Stephen Hemminger wrote: > > On Thu, 2 Jan 2025 14:32:43 -0800 > > Andre Muezerie <andre...@linux.microsoft.com> wrote: > > > > > __builtin_add_overflow is gcc specific. There's a need for a portable > > > version that can also be used with other compilers. > > > > > > Andre Muezerie (5): > > > maintainers: add portable version of __builtin_add_overflow > > > lib/eal: add portable version of __builtin_add_overflow > > > doc/api: add portable version of __builtin_add_overflow > > > drivers/net: use portable version of __builtin_add_overflow > > > app/test: add tests for portable versions of __builtin_add_overflow > > > > > > MAINTAINERS | 1 + > > > app/test/meson.build | 1 + > > > app/test/test_math.c | 125 +++++++++++++++++++++++++++++++++ > > > doc/api/doxy-api-index.md | 1 + > > > drivers/net/ice/base/ice_nvm.c | 9 ++- > > > lib/eal/include/meson.build | 1 + > > > lib/eal/include/rte_math.h | 42 +++++++++++ > > > 7 files changed, 175 insertions(+), 5 deletions(-) > > > create mode 100644 app/test/test_math.c > > > create mode 100644 lib/eal/include/rte_math.h > > > > > > -- > > > 2.47.0.vfs.0.3 > > > > > > > You should add _builtin_add_overflow into the checkpatch naughty list. > > Or maybe all the _builtin_XXX functions? > > Absolutely! Let me add that for a v2 series.
Turns out such check was already added recently (MESSAGE='Using __builtin helpers, prefer EAL macros'), so further changes needed at this point.
