Hi there, To try to improve the ease of use of the framework for the test developer, I have been trying to come up with a decent solution to improve shell handling and consistency. At the moment we have 2 patterns to do this, which could be confusing to the user.
It probably is that a good approach, which is what I am proposing, is to introduce a scoping mechanism in DTS. What this would mean is to associate any shells or modification to different scopes: global test suite and individual test cases. Here's an RFC for this, please have a look. Looking forward to your feedback! This could be massively improved, but it'd require a lot more changes. One idea that I think is worth pursuing is turning the execution into a FSM. Best, Luca Luca Vizzarro (2): dts: add scoping and shell registration to Node dts: revert back shell split dts/framework/remote_session/dpdk_shell.py | 8 +- .../remote_session/interactive_shell.py | 262 +++++++++++++++-- .../single_active_interactive_shell.py | 266 ------------------ dts/framework/remote_session/testpmd_shell.py | 4 +- dts/framework/runner.py | 15 +- dts/framework/testbed_model/capability.py | 35 ++- dts/framework/testbed_model/node.py | 65 ++++- dts/framework/testbed_model/sut_node.py | 14 +- dts/tests/TestSuite_blocklist.py | 16 +- dts/tests/TestSuite_checksum_offload.py | 168 +++++------ dts/tests/TestSuite_dynamic_queue_conf.py | 52 ++-- dts/tests/TestSuite_l2fwd.py | 20 +- dts/tests/TestSuite_mac_filter.py | 124 ++++---- dts/tests/TestSuite_pmd_buffer_scatter.py | 26 +- dts/tests/TestSuite_smoke_tests.py | 4 +- dts/tests/TestSuite_vlan.py | 42 +-- 16 files changed, 575 insertions(+), 546 deletions(-) delete mode 100644 dts/framework/remote_session/single_active_interactive_shell.py -- 2.43.0
