Currently, ixgbe driver initializes PTP timestamp to 0. This is different
from what kernel driver does (which initializes it to system time).
Align the DPDK driver to kernel driver by setting PTP timestamp to system
time when enabling PTP.
Note that ixgbe driver always uses zero-based timestamps for PTP, so we
would only ever update the internal timecounter and not the actual NIC
registers.
Implementation note: in order to get access to clock_gettime on MinGW, we
have to use rte_os_shim.h header, which provides a wrapper around that
function. However, what it *also* provides is wrapper macros around various
other OS-related functions such as read(). Due to one of the mailbox ops
in base code being called "read", MinGW will misinterpret a call into
that op as an attempt to call read() the OS function, and produce a
compile error. This is being worked around by using parentheses around
access to the read op.
Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index d02d1e43a3..277fdbc9f2 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -35,6 +35,7 @@
#ifdef RTE_LIB_SECURITY
#include <rte_security_driver.h>
#endif
+#include <rte_os_shim.h>
#include "ixgbe_logs.h"
#include "base/ixgbe_api.h"
@@ -4168,7 +4169,12 @@ ixgbevf_check_link(struct ixgbe_hw *hw, ixgbe_link_speed
*speed,
/* if the read failed it could just be a mailbox collision, best wait
* until we are called again and don't report an error
*/
- if (mbx->ops[0].read(hw, &in_msg, 1, 0))
+
+ /*
+ * on MinGW, the read op call is interpreted as call into read() macro,
+ * so avoid calling it directly.
+ */
+ if ((mbx->ops[0].read)(hw, &in_msg, 1, 0))
goto out;
if (!(in_msg & IXGBE_VT_MSGTYPE_CTS)) {
@@ -6924,6 +6930,12 @@ ixgbe_timesync_enable(struct rte_eth_dev *dev)
struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
uint32_t tsync_ctl;
uint32_t tsauxc;
+ struct timespec ts;
+
+ memset(&ts, 0, sizeof(struct timespec));
+
+ /* get current system time */
+ clock_gettime(CLOCK_REALTIME, &ts);
/* Stop the timesync system time. */
IXGBE_WRITE_REG(hw, IXGBE_TIMINCA, 0x0);
@@ -6956,6 +6968,9 @@ ixgbe_timesync_enable(struct rte_eth_dev *dev)
IXGBE_WRITE_FLUSH(hw);
+ /* ixgbe uses zero-based timestamping so only adjust timecounter */
+ ixgbe_timesync_write_time(dev, &ts);
+
return 0;
}
--
2.43.5
