> -----Original Message----- > From: Harman Kalra <hka...@marvell.com> > Sent: Monday, November 4, 2024 6:38 PM > To: Nithin Kumar Dabilpuram <ndabilpu...@marvell.com>; Kiran Kumar > Kokkilagadda <kirankum...@marvell.com>; Sunil Kumar Kori > <sk...@marvell.com>; Satha Koteswara Rao Kottidi > <skotesh...@marvell.com>; Harman Kalra <hka...@marvell.com> > Cc: dev@dpdk.org > Subject: [EXTERNAL] [PATCH 2/2] common/cnxk: add mailbox debug trace > > Implementing mailbox debug trace points to trace function calls. > Signed-off-by: > Harman Kalra <hkalra@ marvell. com> --- drivers/common/cnxk/roc_dev. c | 89 > ++++++++++++++++-------------- drivers/common/cnxk/roc_mbox. c | 34 > ++++++++++++ drivers/common/cnxk/roc_mbox. h > Implementing mailbox debug trace points to trace function calls. > > Signed-off-by: Harman Kalra <hka...@marvell.com> > --- > drivers/common/cnxk/roc_dev.c | 89 ++++++++++++++++-------------- > drivers/common/cnxk/roc_mbox.c | 34 ++++++++++++ > drivers/common/cnxk/roc_mbox.h | 2 + > drivers/common/cnxk/roc_platform.c | 9 +++ > drivers/common/cnxk/roc_platform.h | 87 +++++++++++++++++++++++++++-- > 5 files changed, 175 insertions(+), 46 deletions(-) > > diff --git a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c > index 1127d8185c..e9bf8c01b4 100644 > --- a/drivers/common/cnxk/roc_dev.c > +++ b/drivers/common/cnxk/roc_dev.c > @@ -26,7 +26,6 @@ > > /* RVU PF interrupt status as received from AF*/ #define > RVU_PF_INTR_STATUS 0x3 > -
This change may not be needed.
Also, Fix following issues
### [PATCH] common/cnxk: fix mailbox timeout issues
Warning in drivers/common/cnxk/roc_dev.c:
Warning in drivers/common/cnxk/roc_mbox.c:
Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer
rte_atomic_xxx/rte_memory_order_xxx
### [PATCH] common/cnxk: add mailbox debug trace
WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#199: FILE: drivers/common/cnxk/roc_dev.c:907:
+ roc_trace_mbox_process("PRC_UPMSG", mbox_id2name(msg->id),
req_hdr->num_msgs, msg->pcifunc);
WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#212: FILE: drivers/common/cnxk/roc_dev.c:917:
+ plt_err("Error %d handling 0x%x (%s)", err,
msg->id, mbox_id2name(msg->id));
);
<<attachment: winmail.dat>>
