The function strerror() is insecure in a multi-thread environment.
This patch uses strerror_r() to replace it.

Signed-off-by: Dengdui Huang <huangdeng...@huawei.com>
Acked-by: Chengwen Feng <fengcheng...@huawei.com>
Acked-by: Morten Brørup <m...@smartsharesystems.com>
Acked-by: Huisong Li <lihuis...@huawei.com>
---
 lib/node/kernel_tx.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lib/node/kernel_tx.c b/lib/node/kernel_tx.c
index 3a96741622..3a76522799 100644
--- a/lib/node/kernel_tx.c
+++ b/lib/node/kernel_tx.c
@@ -20,6 +20,7 @@ static __rte_always_inline void
 kernel_tx_process_mbuf(struct rte_node *node, struct rte_mbuf **mbufs, 
uint16_t cnt)
 {
        kernel_tx_node_ctx_t *ctx = (kernel_tx_node_ctx_t *)node->ctx;
+       char errmsg[RTE_STRERR_BUFSIZE];
        struct sockaddr_in sin = {0};
        struct rte_ipv4_hdr *ip4;
        size_t len;
@@ -35,8 +36,11 @@ kernel_tx_process_mbuf(struct rte_node *node, struct 
rte_mbuf **mbufs, uint16_t
                sin.sin_port = 0;
                sin.sin_addr.s_addr = ip4->dst_addr;
 
-               if (sendto(ctx->sock, buf, len, 0, (struct sockaddr *)&sin, 
sizeof(sin)) < 0)
-                       node_err("kernel_tx", "Unable to send packets: %s", 
strerror(errno));
+               if (sendto(ctx->sock, buf, len, 0, (struct sockaddr *)&sin, 
sizeof(sin)) < 0) {
+                       if (strerror_r(errno, errmsg, sizeof(errmsg)) != 0)
+                               snprintf(errmsg, sizeof(errmsg), "Unknown error 
%d", errno);
+                       node_err("kernel_tx", "Unable to send packets: %s", 
errmsg);
+               }
        }
 }
 
-- 
2.33.0

Reply via email to