On 9/14/2015 5:44 AM, Thomas Monjalon wrote: > Hi, > > 2015-09-11 12:32, Kyle Larose: >> Looking through the version tree for virtio_rxtx.c, I saw the following >> commit: >> >> http://dpdk.org/browse/dpdk/commit/lib/librte_pmd_virtio?id=8c09c20fb4cde76e53d87bd50acf2b441ecf6eb8 >> >> Does anybody know offhand if the issue fixed by that commit could be the >> root cause of what I am seeing? > I won't have the definitive answer but I would like to use your question > to highlight a common issue in git messages: > > PLEASE, authors of fixes, explain the bug you are fixing and how it can > be reproduced. Good commit messages are REALLY read and useful. Thomas: Thanks for reminder. I am not the author of this specific patch, :). We will try to keep commit message simple, enough and useful. In my opinion, this commit message is totally ok. It doesn't fix anything but remove some unnecessary ring update operations.
> > Thanks > >