Hi Ferruh Yigit, Kirill has acked-by my patch. Can you please have it my patch merged as RC2 11/6 is coming near? Thank you.
Regards, Mingjin > -----Original Message----- > From: Ferruh Yigit <ferruh.yi...@amd.com> > Sent: Wednesday, October 16, 2024 6:03 PM > To: Ye, MingjinX <mingjinx...@intel.com>; Stephen Hemminger > <step...@networkplumber.org> > Cc: dev@dpdk.org; Su, Simei <simei...@intel.com>; Wenjun Wu > <wenjun1...@intel.com>; Rybalchenko, Kirill <kirill.rybalche...@intel.com> > Subject: Re: [PATCH v7] examples/ptpclient: add frequency adjustment > > On 10/16/2024 2:41 AM, Ye, MingjinX wrote: > > Hi Ferruh Yigit, > > > > The patch is in 'Changes Requested' status. Can you review it for me? > > > > Hi Mingjin, > > I don't remember changing the status to "Changes Requested", there may > be a mistake, I will update it as "New". > > At quick look it is good, but can we have a review from Kirill as maintainer > of > the sample application. > > If review comes timely, I can merge it directly to next-net. > > > Regards, > > Mingjin > > > >> -----Original Message----- > >> From: Ferruh Yigit <ferruh.yi...@amd.com> > >> Sent: Wednesday, October 16, 2024 1:58 AM > >> To: Stephen Hemminger <step...@networkplumber.org>; Ye, MingjinX > >> <mingjinx...@intel.com> > >> Cc: dev@dpdk.org; Su, Simei <simei...@intel.com>; Wenjun Wu > >> <wenjun1...@intel.com>; Rybalchenko, Kirill > >> <kirill.rybalche...@intel.com> > >> Subject: Re: [PATCH v7] examples/ptpclient: add frequency adjustment > >> > >> On 10/15/2024 6:43 PM, Stephen Hemminger wrote: > >>> On Tue, 15 Oct 2024 08:22:01 +0000 > >>> Mingjin Ye <mingjinx...@intel.com> wrote: > >>> > >>>> This patch adds PI servo controller to support frequency adjustment > >>>> API for IEEE1588 PTP. > >>>> > >>>> For example, the command for starting ptpclient with PI controller is: > >>>> dpdk-ptpclient -a 0000:81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 -c 1 > >>>> > >>>> Signed-off-by: Simei Su <simei...@intel.com> > >>>> Signed-off-by: Wenjun Wu <wenjun1...@intel.com> > >>>> Signed-off-by: Mingjin Ye <mingjinx...@intel.com> > >>> > >>> This fails build testing, is it depending on some other patch? > >>> > >> > >> It is based on next-net, and uses a new API in next-net. > >> > >> We may proceed with this patch after next-net pulled to main.
