Hi, From: Igor Gutorov <igooto...@gmail.com> Sent: Wednesday, August 7, 2024 11:44 PM To: dev@dpdk.org Cc: Igor Gutorov Subject: [PATCH v3 0/2] net/mlx5: fix reported Rx/Tx desc limits
Hi, Slava > > Is an `int` appropriate for `log_max_wq_sz`? Seems like a `uint8_t` > > is sufficient, but I've left it an `int` for consistency with the > > other `log_max_*` values. > > Right, uint8_t looks to be enough. No objection to optimize others to > uint8_t. Changed log_max_wq_sz to uint8_t in the main patch. The others are changed in a separate patch. Let me know if it'd be preferrable to squash the patches. > > > > > 4. Please, format your patch according to the "fix" template. > > > > I've reworded the commit message a little bit. But I don't see these > > issues on Bugzilla, I've stumbled upon them independently. If you'd > > like the bug reports to be created, let me know. > > I meant this: https://doc.dpdk.org/guides/contributing/patches.html > Please see chapter "8.7. Commit Messages: Body" about "Fixes" and "Cc: > sta...@dpdk.org". It is a bit difficult for me to reference a commit for the "Fixes", since it's a bit hard to call this a regression specifically. I set this tag to the commit that first introduced configuring the device. Is that appropriate? > > Also, please run checking script: /devtools/check-git-log.sh' -1 to > verify commit message compliance. Thanks! No warnings now, except for "Wrong headline prefix" for the first patch because it modifies both common/mlx5 and net/mlx5. I can split the patch into two if needed. v3: * Added uint8_t optimization * Fixed commit messages v2: * Patch reworked to query HCA attributes Igor Gutorov (2): net/mlx5: fix reported Rx/Tx desc limits common/mlx5: reduce HCA attribute type sizes drivers/common/mlx5/mlx5_devx_cmds.c | 1 + drivers/common/mlx5/mlx5_devx_cmds.h | 9 +++++---- drivers/net/mlx5/mlx5_ethdev.c | 4 ++++ drivers/net/mlx5/mlx5_rxq.c | 8 ++++++++ drivers/net/mlx5/mlx5_txq.c | 8 ++++++++ 5 files changed, 26 insertions(+), 4 deletions(-) -- 2.45.2 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
