On Tue, Oct 29, 2024 at 04:07:45PM +0530, Singh, Aman Deep wrote: > On 25-10-2024 15:56, Soumyadeep Hore wrote: > > In ICE PMD, previously the ready bitmap checking before reading > PHY timestamp was not present. This caused incorrect Tx > timestamping. > > The ready bitmap checking is enabled and PHY timestamp is read once > the ready bitmap gives positive value. > > Fixes: 881169950d80 ("net/ice/base: implement initial PTP support for E830") > Cc: [1]sta...@dpdk.org > > Signed-off-by: Soumyadeep Hore [2]<soumyadeep.h...@intel.com> > > Acked-by: Aman Singh [3]<aman.deep.si...@intel.com> > Is this a v5 of this patch, or a resubmission of v1? There are 3 different v1's of this patch, plus a v2, v3 and v4 listed in patchwork, see [1]. I had feedback on v3 of this patch, which I believe is still relevant to this version.
Please keep all revisions of a patch in the one thread and with increasing version number, saves us reviewers getting confused! :-) Also, with each new version, please include a summary below the cutline of what has changed from previous, so we know what to look out for when reviewing. /Bruce [1] https://patches.dpdk.org/project/dpdk/list/?series=&submitter=&state=*&q=fix+incorrect+reading+of+PHY&archive=&delegate=