LGTM
Series-acked-by: Chengwen Feng <fengcheng...@huawei.com>
On 2024/10/26 0:50, Bruce Richardson wrote:
> The warning for address-of-packed-member was being disabled globally in
> DPDK. While for drivers which need to access hardware-defined
> data-structures the use of packed may make sense, for normal libs and
> applications the use of packed data should be generally avoided.
>
> This patchset initially applies some fixes for cases where we are
> unnecessarily causing the warning to trigger. Thereafter the 6th patch
> removes the global enabling of the warning and replaces it with more
> selective disabling for drivers and for a couple of other components
> which have not yet been fixed.
>
> v2:
> * rebase on latest main (rte_ip.h -> rte_ip4.h)
> * remove unnecessary 0-check in IP checksum calc
>
> Bruce Richardson (6):
> ip_frag: remove use of unaligned variable
> efd: remove unnecessary packed attributes
> bus/ifpga: remove packed attribute
> pipeline: remove packed attribute
> net: add smaller IPv4 cksum function for simple cases
> build: limit scope of packed member warning disabling
>
> app/test-eventdev/test_pipeline_common.c | 25 +-----------
> app/test-pmd/icmpecho.c | 23 +----------
> app/test-pmd/txonly.c | 22 +----------
> app/test/packet_burst_generator.c | 49 +-----------------------
> app/test/test_reassembly_perf.c | 29 +-------------
> config/meson.build | 1 -
> drivers/bus/ifpga/bus_ifpga_driver.h | 2 +-
> drivers/meson.build | 9 +++--
> examples/ipsec-secgw/meson.build | 6 +++
> lib/efd/rte_efd.c | 4 +-
> lib/ip_frag/rte_ipv4_reassembly.c | 4 +-
> lib/net/rte_ip4.h | 32 ++++++++++++++++
> lib/pipeline/rte_table_action.c | 2 +-
> lib/vhost/meson.build | 5 ++-
> 14 files changed, 59 insertions(+), 154 deletions(-)
>
> --
> 2.43.0
>
