> Hi Steve, > > I agree these functions are not doing much at the moment, but I would like to > keep them for the reasons below: > > 1. There might be people using them, and we do not want to break their code. > Removing them is an ABI change. > > 2. Although they are just placeholders for now, we might need to add more > functionality to them going forward, as the implementation evolves. I don't > want to change the API now by removing them, and change the API later when we > need to add them back. Generally, I think it is good practice to have free > functions.
The source code base is not a code repository for unused and dead code! If you need to keep things, either get them out of previous history with git or keep them out of tree. Also have a number of patches to remove all #ifdef code that is dead in QoS now.
