[AMD Official Use Only - AMD Internal Distribution Only] Hi Huisong,
> -----Original Message----- > From: lihuisong (C) <lihuis...@huawei.com> > Sent: Tuesday, October 22, 2024 8:47 AM > To: Tummala, Sivaprasad <sivaprasad.tumm...@amd.com> > Cc: dev@dpdk.org; david.h...@intel.com; anatoly.bura...@intel.com; > radu.nico...@intel.com; jer...@marvell.com; cristian.dumitre...@intel.com; > konstantin.anan...@huawei.com; Yigit, Ferruh <ferruh.yi...@amd.com>; > gak...@marvell.com > Subject: Re: [PATCH v7 2/5] power: refactor uncore power management library > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > LGTM except for one typo, > Acked-by: Huisong Li <lihuis...@huawei.com> > > 在 2024/10/21 12:07, Sivaprasad Tummala 写道: > > iThis patch refactors the power management library, addressing uncore > iThis --> This > > power management. The primary changes involve the creation of > > dedicated directories for each driver within 'drivers/power/uncore/*'. > > The adjustment of meson.build files enables the selective activation > > of individual drivers. > > > > This refactor significantly improves code organization, enhances > > clarity and boosts maintainability. It lays the foundation for more > > focused development on individual drivers and facilitates seamless > > integration of future enhancements, particularly the AMD uncore driver. > > > > v7: > > - fixed build error with aarch32 gcc cross compilation > > > > v6: > > - fixed compilation error with symbol export in API > > > > v5: > > - fixed build errors for risc-v/ppc targets > > > > v4: > > - fixed build error with RTE_ASSERT > > > > v3: > > - fixed typo in header file inclusion > <...> ACK! Will fix this in next version
