16/10/2024 10:18, Junlong Wang: > --- a/drivers/net/zxdh/zxdh_msg.c > +++ b/drivers/net/zxdh/zxdh_msg.c > @@ -18,8 +18,6 @@ > #define REPS_INFO_FLAG_USABLE 0x00 > #define BAR_SEQID_NUM_MAX 256 > > -#define ZXDH_BAR0_INDEX 0 > - > #define PCIEID_IS_PF_MASK (0x0800) > #define PCIEID_PF_IDX_MASK (0x0700) > #define PCIEID_VF_IDX_MASK (0x00ff) > @@ -43,7 +41,6 @@ > #define FW_SHRD_OFFSET (0x5000) > #define FW_SHRD_INNER_HW_LABEL_PAT (0x800) > #define HW_LABEL_OFFSET (FW_SHRD_OFFSET + > FW_SHRD_INNER_HW_LABEL_PAT) > -#define ZXDH_CTRLCH_OFFSET (0x2000) > #define CHAN_RISC_SPINLOCK_OFFSET (BAR0_SPINLOCK_OFFSET - > BAR0_CHAN_RISC_OFFSET) > #define CHAN_PFVF_SPINLOCK_OFFSET (BAR0_SPINLOCK_OFFSET - > BAR0_CHAN_PFVF_OFFSET) > #define CHAN_RISC_LABEL_OFFSET (HW_LABEL_OFFSET - > BAR0_CHAN_RISC_OFFSET)
Removing code is strange here. Maybe it should have been placed somewhere else initially?