> -----Original Message----- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Tuesday, September 1, 2015 4:59 AM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Stephen Hemminger > Subject: [PATCH 2/5] example_ip_pipeline: avoid strncpy issue > > If name is so long that it fills buffer, then string would not > be null terminated. > > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org> > --- > examples/ip_pipeline/config_parse_tm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/examples/ip_pipeline/config_parse_tm.c > b/examples/ip_pipeline/config_parse_tm.c > index 84702b0..4a35715 100644 > --- a/examples/ip_pipeline/config_parse_tm.c > +++ b/examples/ip_pipeline/config_parse_tm.c > @@ -354,7 +354,9 @@ tm_cfgfile_load_sched_subport( > profile = atoi(entries[j].value); > strncpy(name, > entries[j].name, > - sizeof(name)); > + CFG_NAME_LEN - 1); > + name[CFG_NAME_LEN-1] = '\0'; > + > n_tokens = rte_strsplit( > &name[sizeof("pipe")], > strnlen(name, > CFG_NAME_LEN), > -- > 2.1.4
Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
