We currently check that exported headers are fine with -DALLOW_EXPERIMENTAL_API and -DALLOW_INTERNAL_API.
Such a check won't catch issues like the one fixed in patch 1, where OVS compilation is broken by the additional of experimental API in a header commonly included in other parts of DPDK. Ideally, I would like to merge patch 1 in rc1. The patch 2 is not a real issue (more like the enhanced check would complain about this header). In any case, I think it would not hurt merging everything now. Comments, please. -- David Marchand Changes since v1: - fixed additional issue in vDPA header, raised by CI, David Marchand (4): bitops: fix build for GCC without experimental API bitset: fix build for GCC without experimental API vhost: remove internal vDPA API description from public header buildtools/chkincs: check headers with stable API only buildtools/chkincs/meson.build | 27 +++++++- lib/eal/include/rte_bitops.h | 6 ++ lib/eal/include/rte_bitset.h | 123 +++++++++++++++++++++++++++++++++ lib/vhost/rte_vdpa.h | 17 ----- 4 files changed, 154 insertions(+), 19 deletions(-) -- 2.46.2
