On Mon, Oct 14, 2024 at 1:12 PM Nitin Saxena <nsax...@marvell.com> wrote: > I had pushed non RFC patch series before -rc1 date (11th oct). > We have an ABI change in this patch series > https://patches.dpdk.org/project/dpdk/patch/20241010133111.2764712-3-nsax...@marvell.com/ > Could you help merge this patch series in rc2 otherwise it has to wait for > next LTS
Just read through the series, I am not confident with this addition. It requires a lot of changes in the node code for supporting it, where it should be something handled in/facilitated by the graph library itself. I did not read much from Robin or Christophe who have been writing more node code than me. I would prefer their opinion before going forward. On the ABI topic. As far as I can see, the only issue would be in extending struct rte_node_register, but this can be solved with function versioning. That change would have to be announced. Am I missing something else? -- David Marchand
