Hi Sergio, On 08.09.2015 14:45, Gonzalez Monroy, Sergio wrote: > Just a few comments/suggestions: > > Add 'eal/linux:' to the commit title, ie: > "eal/linux: change hugepage sorting to avoid overlapping memcpy" >
I would modify the patch according to your notes if needed, but if you consider the other patch from Jay, then I would vote for that instead. Actually, I thought about using qsort too, but decided against it to keep the number of changes low and the sorting speed is not a problem for me. Changing the return value of that function to void might still be a good idea. Best Regards, Ralf -- Ralf Hoffmann Allegro Packets GmbH K?the-Kollwitz-Str. 54 04109 Leipzig HRB 30535, Amtsgericht Leipzig
