On 2024-10-16 06:36, Mattias Rönnblom wrote:
On 2024-10-16 00:00, Stephen Hemminger wrote:
On Tue, 15 Oct 2024 20:25:35 +0200
Mattias Rönnblom <mattias.ronnb...@ericsson.com> wrote:
Remove the single event enqueue and dequeue, since they did not
provide any noticable performance benefits.
This is a change of the ABI, previously announced as a deprecation
notice. These functions were not directly called by the application,
so the API remains unaffected.
Signed-off-by: Mattias Rönnblom <mattias.ronnb...@ericsson.com>
Still have a build failure with one driver.
The wonders of #ifdef <arch>.
I had a closer look at this, and given the elaborate macro-based
machinery and the ARM-only conditional compilation it's better if a
driver maintainer does the required changes.
(It's probably better to start from scratch on the cnxk patch, rather
than looking at anything I did.)
Ashwin Sekhar or Pavan Nikhilesh, is this something you can do?
-------------------------------BEGIN LOGS----------------------------
####################################################################################
#### [Begin job log] "ubuntu-22.04-gcc-shared-aarch64" at step Build
and test
####################################################################################
| ^~~~~~
../drivers/event/cnxk/cn9k_eventdev.c: In function ‘cn9k_sso_fp_fns_set’:
../drivers/event/cnxk/cn9k_eventdev.c:576:20: error: ‘struct
rte_eventdev’ has no member named ‘enqueue’; did you mean ‘ca_enqueue’?
576 | event_dev->enqueue = cn9k_sso_hws_enq;
| ^~~~~~~
| ca_enqueue
../drivers/event/cnxk/cn9k_eventdev.c:576:30: error:
‘cn9k_sso_hws_enq’ undeclared (first use in this function); did you
mean ‘cn9k_sso_hws_link’?
576 | event_dev->enqueue = cn9k_sso_hws_enq;
| ^~~~~~~~~~~~~~~~
| cn9k_sso_hws_link
../drivers/event/cnxk/cn9k_eventdev.c:584:28: error: ‘struct
rte_eventdev’ has no member named ‘enqueue’; did you mean ‘ca_enqueue’?
584 | event_dev->enqueue = cn9k_sso_hws_dual_enq;
| ^~~~~~~
| ca_enqueue
../drivers/event/cnxk/cn9k_eventdev.c:584:38: error:
‘cn9k_sso_hws_dual_enq’ undeclared (first use in this function); did
you mean ‘cn9k_sso_hws_dual_ca_enq’?
584 | event_dev->enqueue = cn9k_sso_hws_dual_enq;
| ^~~~~~~~~~~~~~~~~~~~~
| cn9k_sso_hws_dual_ca_enq
[2451/4290] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk at
sta/event_cnxk_deq_cn9k_deq_64_79_seg_burst.c.o'.
[2452/4290] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk at
sta/event_cnxk_deq_cn9k_deq_80_95_seg_burst.c.o'.
[2453/4290] Generating rte_crypto_octeontx.sym_chk with a meson_exe.py
custom command.
[2454/4290] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk at
sta/event_cnxk_deq_cn9k_deq_96_111_seg_burst.c.o'.
[2455/4290] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk at
sta/event_cnxk_deq_cn9k_deq_112_127_seg_burst.c.o'.
ninja: build stopped: subcommand failed.
##[error]Process completed with exit code 1.
####################################################################################
#### [End job log] "ubuntu-22.04-gcc-shared-aarch64" at step Build and
test
####################################################################################
--------------------------------END LOGS-----------------------------
