From: Rohit Raj <rohit....@nxp.com>
Free vfio_group_fd if add group fails to avoid ersource leak
NXP coverity-id: 26661846
Signed-off-by: Rohit Raj <rohit....@nxp.com>
---
drivers/bus/fslmc/fslmc_vfio.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c
index c4be89e3d5..19ad36f5f0 100644
--- a/drivers/bus/fslmc/fslmc_vfio.c
+++ b/drivers/bus/fslmc/fslmc_vfio.c
@@ -347,8 +347,10 @@ fslmc_vfio_open_group_fd(const char *group_name)
} else {
ret = fslmc_vfio_add_group(vfio_group_fd, iommu_group_num,
group_name);
- if (ret)
+ if (ret) {
+ close(vfio_group_fd);
return ret;
+ }
}
return vfio_group_fd;
@@ -1480,6 +1482,8 @@ fslmc_vfio_setup_group(void)
if (vfio_group_fd <= 0) {
vfio_group_fd = fslmc_vfio_open_group_fd(group_name);
if (vfio_group_fd <= 0) {
+ if (!vfio_group_fd)
+ close(vfio_group_fd);
DPAA2_BUS_ERR("Failed to create MC VFIO group");
return -rte_errno;
}
--
2.25.1
