On 10/11/2024 9:02 AM, Bruce Richardson wrote: > On Fri, Oct 11, 2024 at 06:34:06AM +0000, Mingjin Ye wrote: >> Add ice support for new ethdev API to adjust frequency for IEEE1588 >> PTP. Also, this patch reworks code for converting software update >> to hardware update. >> >> Signed-off-by: Simei Su <simei...@intel.com> >> Signed-off-by: Mingjin Ye <mingjinx...@intel.com> >> --- >> doc/guides/nics/ice.rst | 16 ++++ >> drivers/net/ice/ice_ethdev.c | 176 ++++++++++++++++++++++++++--------- >> drivers/net/ice/ice_ethdev.h | 5 +- >> drivers/net/ice/ice_rxtx.c | 4 +- >> 4 files changed, 153 insertions(+), 48 deletions(-) >> >> diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst >> index ae975d19ad..061c8c7a20 100644 >> --- a/doc/guides/nics/ice.rst >> +++ b/doc/guides/nics/ice.rst >> @@ -328,6 +328,22 @@ Forward Error Correction (FEC) >> >> Supports get/set FEC mode and get FEC capability. >> >> +Time Synchronisation >> +~~~~~~~~~~~~~~~~~~~~ >> + >> +The system operator can run a PTP (Precision Time Protocol) client >> application >> +to synchronise the time on the network card (and optionally the time on the >> +system) to the PTP master. >> + >> +ICE PMD supports PTP client applications that use the DPDK IEEE1588 API to >> +communicate with the PTP master clock. Note that PTP client application >> needs >> +to run on PF and add the ``--force-max-simd-bitwidth=64`` startup parameter >> to >> +disable vector mode. >> + >> +.. code-block:: console >> + >> + examples/dpdk-ptpclient -c f -n 3 -a 0000:ec:00.1 >> --force-max-simd-bitwidth=64 -- -T 1 -p 0x1 -c 1 >> + > > It's a pity that the vector disabling doesn't happen automatically > somewhere and that we have to ask the user to pass in the flag. Maybe see > if that can be improved for RC2 or next release? > > Anyway, for this patch: > > Acked-by: Bruce Richardson <bruce.richard...@intel.com> >
Applied to dpdk-next-net/main, thanks.